fix(metrics): avoid intialize un-necessary system resources #2624
+101
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maqi
force-pushed
the
avoid_scan_entire_sys_during_cpu_threshold_check
branch
from
15f045f to
189f0b7
Compare
maqi
force-pushed
the
avoid_scan_entire_sys_during_cpu_threshold_check
branch
2 times, most recently
from
0d1c4c4 to
5b66cf4
Compare
maqi
changed the title
maqi
force-pushed
the
avoid_scan_entire_sys_during_cpu_threshold_check
branch
3 times, most recently
from
83aa553 to
3cc28cd
Compare
maqi
changed the title
It turned out that new_all function opens FD for un-necessary system resources, which result in accumulated memory-usage issue. Hence initialize with nothing and then refresh only related.
maqi
force-pushed
the
avoid_scan_entire_sys_during_cpu_threshold_check
branch
from
3cc28cd to
146651d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It turned out that new_all function opens FD for un-necessary system resources, which result in accumulated memory-usage issue.
Hence initialize with nothing and then refresh only related.
This PR also contains the CI test to confirm there is no extra and acculuated FDs to be held by the node process.
Type of Change
Please mark the types of changes made in this pull request.